Optimize code size in MINIMAL_RUNTIME: not all users want to override INITIAL_MEMORY via Module. #25353
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… INITIAL_MEMORY via Module.
sbc100
reviewed
Sep 22, 2025
| #if MINIMAL_RUNTIME | ||
| var INITIAL_MEMORY = {{{ INITIAL_MEMORY }}}; | ||
| #else | ||
| var INITIAL_MEMORY = {{{ makeModuleReceiveExpr('INITIAL_MEMORY', INITIAL_MEMORY) }}}; |
There was a problem hiding this comment.
The makeModuleReceiveExpr macro already takes care of this I think.
IIRC, MINIMAL_RUNTIME sets INCOMING_MODULE_JS_API to empty by default which should make this expand to just INITIAL_MEMORY
There was a problem hiding this comment.
It looks like this does not happen by default, but testing this now, indeed if I manually set -sINCOMING_MODULE_JS_API=[], then this does happen. So that's good solution for this, closing this PR.
|
Should we default |
|
Yeah, I think that would probably work out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize code size in MINIMAL_RUNTIME: not all users want to override INITIAL_MEMORY via Module.